[CodeStyle][PLR0206] Cannot have defined parameters for properties (#…

…52539)
PaddlePaddle · Apr 5, 2023 · ea8aa43 · ea8aa43
1 parent 2236286
commit ea8aa43
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 23 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -96,7 +96,7 @@ select = [
     # "PLE2514",
     # "PLE2515",
     # "PLR0133",
-    # "PLR0206",
+    "PLR0206",
     "PLR0402",
     # "PLR0911",
     # "PLR0912",

diff --git a/test/dygraph_to_static/simnet_dygraph_model.py b/test/dygraph_to_static/simnet_dygraph_model.py
@@ -16,7 +16,6 @@
 
 import paddle
 import paddle.fluid.param_attr as attr
-from paddle.common_ops_import import Variable
 from paddle.jit.api import to_static
 from paddle.nn import Layer
 
@@ -363,16 +362,6 @@ def _build_once(self, input):
             attr=self._bias_attr, shape=size, dtype=self._dtype, is_bias=True
         )
 
-    # TODO(songyouwei): We should remove _w property
-    @property
-    def _w(self, i=0):
-        return self.__w[i]
-
-    @_w.setter
-    def _w(self, value, i=0):
-        assert isinstance(self.__w[i], Variable)
-        self.__w[i].set_value(value)
-
     @property
     def weight(self):
         if len(self.__w) > 1:

diff --git a/test/dygraph_to_static/simnet_dygraph_model_v2.py b/test/dygraph_to_static/simnet_dygraph_model_v2.py
@@ -15,7 +15,6 @@
 from functools import reduce
 
 import paddle
-from paddle.common_ops_import import Variable
 
 
 class EmbeddingLayer:
@@ -349,16 +348,6 @@ def _build_once(self, input):
             attr=self._bias_attr, shape=size, dtype=self._dtype, is_bias=True
         )
 
-    # TODO(songyouwei): We should remove _w property
-    @property
-    def _w(self, i=0):
-        return self.__w[i]
-
-    @_w.setter
-    def _w(self, value, i=0):
-        assert isinstance(self.__w[i], Variable)
-        self.__w[i].set_value(value)
-
     @property
     def weight(self):
         if len(self.__w) > 1: