Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
This uses shlex for safe command parsing to fix arbitrary code injection

Co-authored-by: ndren <andreien@proton.me>
  • Loading branch information
wanghuancoder and ndren authored Jan 31, 2024
1 parent 0227a0d commit f99d4f2
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion python/paddle/utils/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import hashlib
import os
import os.path as osp
import shlex
import shutil
import subprocess
import sys
Expand Down Expand Up @@ -204,7 +205,8 @@ def _wget_download(url: str, fullname: str):
'https',
), 'Only support https and http url'
# using wget to download url
tmp_fullname = fullname + "_tmp"
tmp_fullname = shlex.quote(fullname + "_tmp")
url = shlex.quote(url)
# –user-agent
command = f'wget -O {tmp_fullname} -t {DOWNLOAD_RETRY_LIMIT} {url}'
subprc = subprocess.Popen(
Expand Down

0 comments on commit f99d4f2

Please sign in to comment.