-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard pre-commit hooks #2289
Comments
I noticed this issue because when I was trying to fix the pre-commit error of #2288, I had to use the upstream hooks repo; otherwise, I wouldn't be able to reformat the Python code. |
reyoung
added a commit
to reyoung/Paddle
that referenced
this issue
May 31, 2017
* use PaddlePaddle org to manage mirrors-yapf * Fix PaddlePaddle#2289
@reyoung told that the version of yapf is critical. So we forked pre-commit's standard hooks to organization PaddlePaddle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In /.pre-commit-config.yaml, we refer to
repo: https://github.com/reyoung/mirrors-yapf.git, which is a fork of https://github.com/pre-commit/mirrors-yapf. The difference is and is only changing the version of
yapf
from 0.11.3 to 0.13.2, as shown here.Is this versioning critical? If not, how about we just use the upstream https://github.com/pre-commit/mirrors-yapf? If it is critical, how about we create a fork under PaddlePaddle?
The text was updated successfully, but these errors were encountered: