Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package a new USE_NO_KERNEL_OP for USE_OP_ITSELF #3848

Closed
luotao1 opened this issue Sep 4, 2017 · 0 comments · Fixed by #3851
Closed

package a new USE_NO_KERNEL_OP for USE_OP_ITSELF #3848

luotao1 opened this issue Sep 4, 2017 · 0 comments · Fixed by #3851
Assignees

Comments

@luotao1
Copy link
Contributor

luotao1 commented Sep 4, 2017

Currently, there are two USE_OP_ITSELF ops.

USE_OP_ITSELF(recurrent);
USE_OP_ITSELF(identity);

And the diffence between USE_OP_ITSELF and USE_OP is whether ops has kernel.

#define USE_OP(op_type)   \
  USE_OP_ITSELF(op_type); \
  USE_OP_KERNEL(op_type)

However, USE_OP and USE_CPU_ONLY_OP are the same level, USE_OP_ITSELF is a sub-level in USE_OP currently.

Discussing with @Canpio , we will package a new USE_NO_KERNEL_OP for USE_OP_ITSELF. Thus, when adding new ops, developers can use one of USE_OP , USE_CPU_ONLY_OP and USE_NO_KERNEL_OP to register.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants