Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests of op_registry_test should be in operator_test #3891

Closed
JiayiFeng opened this issue Sep 5, 2017 · 0 comments · Fixed by #3892
Closed

Some tests of op_registry_test should be in operator_test #3891

JiayiFeng opened this issue Sep 5, 2017 · 0 comments · Fixed by #3892
Assignees
@JiayiFeng

Comments

@JiayiFeng
Copy link
Collaborator 

TEST(ProtoMaker, DuplicatedAttr)
TEST(ProtoMaker, DuplicatedInOut)

The above two tests test class OpProtoAndCheckerMaker, so obviously they shall be in operator_test. They are now in op_registry_test because when we wrote these two tests the design of OperatorBase had not be completed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiayiFeng JiayiFeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move two tests form op_registry_test to operator_test JiayiFeng/Paddle
1 participant
@JiayiFeng