Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no execution permission in demo/semantic_role_labeling by default #705

Closed
leonardgithub opened this issue Dec 2, 2016 · 4 comments · Fixed by #725
Closed

no execution permission in demo/semantic_role_labeling by default #705

leonardgithub opened this issue Dec 2, 2016 · 4 comments · Fixed by #725
Assignees

Comments

@leonardgithub
Copy link

I use the paddledev/paddle:cpu-devel-latest image, but I found the sh and py files are without x permission in the folder /root/paddle/demo/semantic_role_labeling, It is recommended you add the x permission like other demo such as quick_start/*.sh

commands:
chmod +x *.sh
chmod +x *.py

@backyes backyes added the wontfix label Dec 2, 2016
@backyes
Copy link
Contributor

backyes commented Dec 2, 2016

@leonardgithub

Thanks for your report. :-)

I remember that he shell script will call python script indirectly. Generally, we will prefer to call shell script with sh some.sh. For source distribution, I think current solution would be better. :-)

@backyes backyes closed this as completed Dec 2, 2016
@leonardgithub
Copy link
Author

@backyes I agree with you, but why in other demo such as quick_start, the sh files have x permission. It is not consistent.

@backyes
Copy link
Contributor

backyes commented Dec 2, 2016

@leonardgithub

We will try to fix it, thanks.

@backyes backyes assigned backyes and unassigned llxxxll Dec 2, 2016
@backyes
Copy link
Contributor

backyes commented Dec 2, 2016

@leonardgithub

Would like to contribute it to help us to make it perfect. :-)

@backyes backyes reopened this Dec 2, 2016
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this issue Sep 25, 2019
lizexu123 pushed a commit to lizexu123/Paddle that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants