Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevicePtrCast is only defined and used in device_ptr_cast.h #9857

Closed
wangkuiyi opened this issue Apr 12, 2018 · 3 comments
Closed

DevicePtrCast is only defined and used in device_ptr_cast.h #9857

wangkuiyi opened this issue Apr 12, 2018 · 3 comments
Assignees
@wangkuiyi

Comments

@wangkuiyi
Copy link
Collaborator

According to this Github code search result, it seems that DevicePtrCast is only defined and used in one source file.

Should we remove this file?
@wangkuiyi
Copy link
Collaborator Author

paddle/fluid/platform/transform.h includes device_ptr_cast.h, but doesn't use DevicePtrCast.

@wangkuiyi wangkuiyi mentioned this issue Apr 12, 2018
Closed
@wangkuiyi wangkuiyi self-assigned this Apr 12, 2018
@wangkuiyi
Copy link
Collaborator Author

OK, I see that in device_ptr_cast.h, there are DevicePtrCast and DevPtrCast. What is used in transform.h is DevPtrCast.

@wangkuiyi wangkuiyi mentioned this issue Apr 12, 2018
Closed
@wangkuiyi
Copy link
Collaborator Author

Due the reason described in #9861 (comment), I am closing this issue.

This was referenced Apr 13, 2018
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangkuiyi wangkuiyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wangkuiyi