Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpplint errors in transform_test.cu #9915

Merged
merged 2 commits into from
Apr 14, 2018

Conversation

wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Apr 13, 2018

Fixes #9857

This PR includes #9913.

tonyyang-svail
tonyyang-svail previously approved these changes Apr 13, 2018
Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added documentation and better naming. LGTM

@wangkuiyi wangkuiyi force-pushed the cpplint-transform-test-cu branch from 7016b3a to b5696b3 Compare April 14, 2018 00:04
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangkuiyi wangkuiyi merged commit b48cf17 into PaddlePaddle:develop Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants