Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance comparison of some frameworks. #10120

Closed
wants to merge 22 commits into from

Conversation

gongweibao
Copy link
Contributor

No description provided.

@gongweibao gongweibao changed the title [WIP]Performance comparison of some frameworks. Performance comparison of some frameworks. May 16, 2018
</table>


## Conclution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the unit of this figure

@panyx0718
Copy link
Contributor

I notice the code used for testing grpc is using Paddle's threadpool. Can you change to use pthread similar to the brpc experiment. Also, it would be great to simplify your grpc experiment to be as similar to brpc experiment as possible

@panyx0718
Copy link
Contributor

Could there be extra over head to create threads in threads?
https://github.com/gongweibao/tests/blob/develop/grpc_test/client.cc#L172

@panyx0718
Copy link
Contributor

https://github.com/gongweibao/tests/blob/develop/grpc_test/client.cc#L165
compared with brpc experiment, which creates channel outside timing zone, grpc experiment is creating channel within timing zone

@panyx0718
Copy link
Contributor

https://github.com/Tuvie/brpc/blob/master/benchmark/client.cpp#L49
brpc seems to be using sync call.

https://github.com/gongweibao/tests/blob/develop/grpc_test/client.cc#L71
while grpc is using async with maximum of 3 nested levels of threads.

@gongweibao
Copy link
Contributor Author

gongweibao commented May 21, 2018

It seems that they are not the key problem of performance.
It open an ISSUE in GRPC some days ago:grpc/grpc#15348

@paddle-bot-old paddle-bot-old bot closed this May 22, 2020
@paddle-bot-old
Copy link

Since you haven't replied for a long time, we have closed this issue/pr.
If the problem is not solved or there is a follow-up one, please reopen it at any time and we will continue to follow up.
由于您长期未回复,我们将关闭这个issue/pr。
若问题未解决或有后续问题,请随时重新打开,我们会继续跟进。

@gongweibao gongweibao deleted the networktest branch January 17, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants