Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of pooling mkldnn primitives #10747

Merged
merged 1 commit into from
May 21, 2018

Conversation

jczaja
Copy link
Contributor

@jczaja jczaja commented May 17, 2018

Changes are introducing reusing concept of MKLDNN primitives for pool MKLDNN operator of FLUID.

There is also a functionality added to bind memory primitives data type (f32) with template parameter eg. "float" .

- Finished draft of pooling reusing of operators

- Using gethash in PoolGrad added

- Removed diagnostic

- Added pool mkldnn grad reusing of primitives

- Added diagnostic

- Removed diagnostic

- added dependency to mkldnn data type for pooling mkldnn

- Added mkldnn memory data type determining based on template type of op

- Compilation warning fix

- codying style fixes
@kbinias kbinias requested a review from luotao1 May 17, 2018 10:21
@kbinias kbinias added the Intel label May 17, 2018
@luotao1 luotao1 requested a review from tensor-tang May 17, 2018 10:49
Copy link
Contributor

@tensor-tang tensor-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, what do you think @luotao1

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 85b6bb5 into PaddlePaddle:develop May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants