Clean not need ctx arguments. #10842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
May 23, 2018
| auto var = var_h.scope->FindVar(var_h.name); | ||
|
|
||
| platform::Place place = platform::CPUPlace(); | ||
| if (var->IsType<framework::LoDTensor>()) { |
There was a problem hiding this comment.
Add a function to get the place？
jacquesqiao
reviewed
May 23, 2018
| } else if (var->IsType<framework::SelectedRows>()) { | ||
| place = var->Get<framework::SelectedRows>().place(); | ||
| #ifdef PADDLE_WITH_CUDA | ||
| } else if (var->IsType<ncclUniqueId>()) { |
There was a problem hiding this comment.
No return value for this branch.
There was a problem hiding this comment.
It uses the default value.
Done.
jacquesqiao
reviewed
May 23, 2018
| @@ -196,6 +189,8 @@ class RPCClient { | |||
| grpc::CompletionQueue cq_; | |||
| std::map<std::string, std::shared_ptr<grpc::Channel>> channels_; | |||
| int64_t req_count_ = 0; | |||
|
|
|||
| static const int64_t rpc_time_out = 600 * 1000; | |||
There was a problem hiding this comment.
rpc_time_out ==> kRpcTimeOut
https://google.github.io/styleguide/cppguide.html#Constant_Names
|
Since you haven't replied for a long time, we have closed this issue/pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #10804