Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute name in new API #10947

Merged
merged 1 commit into from
May 26, 2018
Merged

Fix attribute name in new API #10947

merged 1 commit into from
May 26, 2018

Conversation

sidgoyal78
Copy link
Contributor

This modifies the book examples to have params_dirname attribute.

@sidgoyal78 sidgoyal78 requested review from jetfuel and daming-lu May 25, 2018 23:25
daming-lu
daming-lu approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@daming-lu daming-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sidgoyal78 sidgoyal78 merged commit fb43c6b into PaddlePaddle:develop May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daming-lu daming-lu daming-lu approved these changes

@jetfuel jetfuel Awaiting requested review from jetfuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidgoyal78 @daming-lu