-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup transpiler and move weight decay and clip on pservers #11039
Merged
typhoonzero
merged 9 commits into
PaddlePaddle:develop
from
typhoonzero:cleanup_transpiler
May 31, 2018
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9ac6bb8
WIP move weight decay
a23bef6
weight decay ok
833563b
wip
71344c7
clean up transpiler
67bd92b
merge weight decay move to pserver
c075ea4
add details folder
5615baf
update
5660c0c
fix split var test
7ca5bb6
follow comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from program_utils import * | ||
from ufind import * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
def delete_ops(block, ops): | ||
try: | ||
start = list(block.ops).index(ops[0]) | ||
end = list(block.ops).index(ops[-1]) | ||
[block.remove_op(start) for _ in xrange(end - start + 1)] | ||
except Exception, e: | ||
raise e | ||
block.program.sync_with_cpp() | ||
|
||
|
||
def find_op_by_input_arg(block, arg_name): | ||
for index, op in enumerate(block.ops): | ||
if arg_name in op.input_arg_names: | ||
return index | ||
return -1 | ||
|
||
|
||
def find_op_by_output_arg(block, arg_name): | ||
for index, op in enumerate(block.ops): | ||
if arg_name in op.output_arg_names: | ||
return index | ||
return -1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
class UnionFind(object): | ||
""" Union-find data structure. | ||
|
||
Union-find is a data structure that keeps track of a set of elements partitioned | ||
into a number of disjoint (non-overlapping) subsets. | ||
|
||
Reference: | ||
https://en.wikipedia.org/wiki/Disjoint-set_data_structure | ||
|
||
Args: | ||
elements(list): The initialize element list. | ||
""" | ||
|
||
def __init__(self, elementes=None): | ||
self._parents = [] # index -> parent index | ||
self._index = {} # element -> index | ||
self._curr_idx = 0 | ||
if not elementes: | ||
elementes = [] | ||
for ele in elementes: | ||
self._parents.append(self._curr_idx) | ||
self._index.update({ele: self._curr_idx}) | ||
self._curr_idx += 1 | ||
|
||
def find(self, x): | ||
# Find the root index of given element x, | ||
# execute the path compress while findind the root index | ||
if not x in self._index: | ||
return -1 | ||
idx = self._index[x] | ||
while idx != self._parents[idx]: | ||
t = self._parents[idx] | ||
self._parents[idx] = self._parents[t] | ||
idx = t | ||
return idx | ||
|
||
def union(self, x, y): | ||
# Union two given element | ||
x_root = self.find(x) | ||
y_root = self.find(y) | ||
|
||
if x_root == y_root: | ||
return | ||
self._parents[x_root] = y_root | ||
|
||
def is_connected(self, x, y): | ||
# If two given elements have the same root index, | ||
# then they are connected. | ||
return self.find(x) == self.find(y) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move these functions into
program.py
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function was moved out from
framework.py
before because we haveremove_op
already, and this function is only used by distributed transpiler.