Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster RecordIO Scanner #11116

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Faster RecordIO Scanner #11116

merged 2 commits into from
Jun 5, 2018

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jun 1, 2018

The previous scanner read the whole chunk at once. It is slow when just open a file.

@reyoung reyoung requested a review from JiayiFeng June 1, 2018 06:50
JiayiFeng
JiayiFeng approved these changes Jun 1, 2018
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It works in my benchmark code.

@reyoung reyoung merged commit 78afcbf into PaddlePaddle:develop Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @JiayiFeng