Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sequence expand op #11618

Merged
merged 14 commits into from
Jun 27, 2018
Merged

Fix sequence expand op #11618

Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1381f9a
Alloc memory for output grad
Jun 21, 2018
b561ab8
Merge branch 'develop' into fix-seqexp
Jun 26, 2018
5b92a63
Try tensor copy to fix
Jun 26, 2018
e40babd
Merge remote-tracking branch 'upstream/develop' into fix-seqexp
Jun 26, 2018
b10f958
Set temp tensor to zero
Jun 26, 2018
6ce2e0c
Merge branch 'fix-seqexp' of github.com:ktlichkid/Paddle into fix-seqexp
Jun 26, 2018
3527d30
param fix
Jun 26, 2018
16629be
clean up
Jun 26, 2018
2b09a6e
rm temp tensor, set g_x to 0
Jun 26, 2018
5883078
Merge branch 'fix-seqexp' of github.com:ktlichkid/Paddle into fix-seqexp
Jun 26, 2018
ecca7a9
clean up
Jun 26, 2018
2f79823
Set zero outside functor
Jun 26, 2018
8cea236
Remove comment
Jun 27, 2018
bd0e414
Merge remote-tracking branch 'upstream/develop' into fix-seqexp
Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions paddle/fluid/operators/sequence_expand_op.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ struct SequenceExpandGradFunctor<platform::CPUDeviceContext, T> {
const framework::Vector<size_t>& x_lod, /*expand source lod*/
const framework::Vector<size_t>& ref_lod, /*expand referenced lod*/
LoDTensor* dx) {
math::SetConstant<platform::CPUDeviceContext, T> set_zero;
set_zero(context, dx, static_cast<T>(0));
// math::SetConstant<platform::CPUDeviceContext, T> set_zero;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these two lines

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// set_zero(context, dx, static_cast<T>(0));

int dout_offset = 0;
for (size_t i = 1; i < ref_lod.size(); ++i) {
Expand Down Expand Up @@ -187,6 +187,10 @@ class SequenceExpandGradKernel : public framework::OpKernel<T> {
g_x->mutable_data<T>(context.GetPlace());
g_x->set_lod(x->lod());

auto& dev_ctx = context.template device_context<DeviceContext>();
math::SetConstant<DeviceContext, T> set_zero;
set_zero(dev_ctx, g_x, static_cast<T>(0));

auto& y_lod = y->lod();
if (ref_level == -1) ref_level = y_lod.size() - 1;
// just copy the gradient
Expand Down