Update detection API add new check document #15848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
reviewed
Feb 24, 2019
paddle/scripts/paddle_build.sh
Outdated
| @@ -451,10 +451,10 @@ function assert_api_spec_approvals() { | |||
| if [ ${API_CHANGE} ] && [ "${GIT_PR_ID}" != "" ]; then | |||
| # NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable. | |||
| APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \ | |||
| python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 2887803` | |||
| python ${PADDLE_ROOT}/tools/check_pr_approval.py 2 2887803 35982308` | |||
There was a problem hiding this comment.
I think only API.spec change need PM approval. Other files, like op_desc.h doesn't need PM approval.
There was a problem hiding this comment.
I think you're right. I added an if judgment.
panyx0718
previously approved these changes
Feb 27, 2019
shanyi15
previously approved these changes
Feb 27, 2019
tianshuo78520a
dismissed stale reviews from shanyi15 and panyx0718
via
74a6f49
panyx0718
previously approved these changes
Feb 27, 2019
shanyi15
previously approved these changes
Feb 27, 2019
tianshuo78520a
dismissed stale reviews from shanyi15 and panyx0718
via
4c77996
shanyi15
previously approved these changes
Feb 27, 2019
panyx0718
previously approved these changes
Feb 27, 2019
tianshuo78520a
dismissed stale reviews from panyx0718 and shanyi15
via
4edb54d
shanyi15
previously approved these changes
Feb 28, 2019
panyx0718
previously approved these changes
Feb 28, 2019
tianshuo78520a
dismissed stale reviews from panyx0718 and shanyi15
via
5a3ba84
shanyi15
previously approved these changes
Mar 1, 2019
panyx0718
previously approved these changes
Mar 1, 2019
shanyi15
approved these changes
Mar 1, 2019
panyx0718
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update detection API add new check document