add op type in check nan/inf #15986
Merged
add op type in check nan/inf #15986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
seiriosPlus
requested review from
chengduoZH,
panyx0718 and
typhoonzero
and removed request for
chengduoZH and
panyx0718
typhoonzero
previously approved these changes
Feb 28, 2019
paddle/fluid/framework/operator.cc
Outdated
| @@ -882,7 +882,8 @@ class RuntimeInferShapeContext : public InferShapeContext { | |||
| const RuntimeContext& ctx_; | |||
| }; | |||
|
|
|||
| static void CheckTensorNANOrInf(const std::string& name, | |||
| static void CheckTensorNANOrInf(const std::string& type, | |||
There was a problem hiding this comment.
name it op_type should be easy to read
chengduoZH
reviewed
Mar 1, 2019
| } else if (var->IsType<framework::SelectedRows>()) { | ||
| CheckTensorNANOrInf(vname, var->Get<framework::SelectedRows>().value()); | ||
| CheckTensorNANOrInf(type_, vname, | ||
| var->Get<framework::SelectedRows>().value()); |
There was a problem hiding this comment.
In fact, if we set the FLAGS_check_nan_inf=1 and GLOG_vmodule=operator=4, we can know the nan/inf is happend in which op.
There was a problem hiding this comment.
yes, I'm agreed. But it may print much more logs I will not expect.
chengduoZH
approved these changes
Mar 1, 2019
ceci3
pushed a commit
to ceci3/Paddle
that referenced
this pull request
Mar 4, 2019
* add op name in check nan/inf, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.