Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MKL-DNN: Add a unit test for pooling when ceil mode is enabled #16013

Merged
merged 1 commit into from
Mar 1, 2019
Merged

MKL-DNN: Add a unit test for pooling when ceil mode is enabled #16013

merged 1 commit into from
Mar 1, 2019

Conversation

kbinias
Copy link
Contributor

@kbinias kbinias commented Mar 1, 2019 •
edited
Loading

Adds a unit test for pooling when ceil mode is enabled (instead of floor) to compute the output shape.

Code coverage (lines/functions):

  • Previous: 85.9% / 76.7%
  • Current: 94.6% / 83.3%

Releated to #15615

@kbinias kbinias added the Intel label Mar 1, 2019
@kbinias kbinias requested review from mozga-intel and luotao1 March 1, 2019 12:06
luotao1
luotao1 approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@luotao1 luotao1 merged commit 96f7fc6 into PaddlePaddle:develop Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@mozga-intel mozga-intel Awaiting requested review from mozga-intel

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbinias @luotao1