Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some bug when merge sparse embedding parameters, test=develop #18223

Merged
merged 3 commits into from
Jun 21, 2019

Conversation

a6802739
Copy link
Contributor

@a6802739 a6802739 commented Jun 20, 2019

fix some bug when merge sparse embedding parameters:

1.fix the bug that out_put_var in SaveSelectedRows would be empty string
2.use merge_sparse_lookup_table to replace sum op for load_persistables_for_inference
3.fix the bug in clone_var_in_block when the var is SELECTED_ROWS.

a6802739 added 3 commits June 20, 2019 13:03
1. fix the bug that out_put_var in SaveSelectedRows would be empty string
2. use merge_sparse_lookup_table to replace sum op for load_persistables_for_inference
3. fix the bug in _clone_var_in_block_ when the var is SELECTED_ROWS.

test=develop
Copy link
Collaborator

@seiriosPlus seiriosPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seiriosPlus seiriosPlus merged commit 6b3d962 into PaddlePaddle:develop Jun 21, 2019
@a6802739 a6802739 deleted the fix_bug branch June 21, 2019 07:56
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Aug 28, 2019
…ddlePaddle#18223)

1. fix the bug that out_put_var in SaveSelectedRows would be empty string
2. use merge_sparse_lookup_table to replace sum op for load_persistables_for_inference
3. fix the bug in _clone_var_in_block_ when the var is SELECTED_ROWS.
seiriosPlus added a commit that referenced this pull request Aug 29, 2019
* fix bug in Class MultiSlotDataGenerator's function _gen_str, test=develop (#18222)
* fix some bug when merge sparse embedding parameters, test=develop (#18223)
* fix communicator with pyreader (#18350)
* delete AllocatorFacade destructor  (#18606)
* fix distribute transpiler GRPC error code 4, RPC Deadline (#18984)
* merge pr #18441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants