Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused TransposeINT8MKLDNNOpKernel for higher UT coverage #18791

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

lidanqing-intel
Copy link
Contributor

@lidanqing-intel lidanqing-intel commented Jul 24, 2019

remove unused TransposeINT8MKLDNNOpKernel for higher UT coverage.
This TransposeINT8MKLDNNOpKernel only surpport axis with [0, 2, 3, 1]

The funciton coverage has similar problem as in #15615 (comment)

coverage of transpose_mkldnn_op.cc

-- Lines Functions
Before 72.9 % 27.8 %
After 98.2% 41.7%

@luotao1
Copy link
Contributor

luotao1 commented Jul 25, 2019

It seems random fails on Python35 three times:

  1. http://ci.paddlepaddle.org/viewLog.html?buildId=131032&tab=buildLog&buildTypeId=Paddle_PrCiPython35&logTab=tree&filter=all&_focus=11593
[18:13:17]	The following tests FAILED:
[18:13:17]		214 - test_dist_mnist_multi_comm (Timeout)
[18:13:17]	Errors while running CTest
[18:13:24]	23/23 Test #491: test_dist_mnist_hallreduce ................***Timeout 350.02 sec
  1. http://ci.paddlepaddle.org/viewLog.html?buildId=131232&tab=buildLog&buildTypeId=Paddle_PrCiPython35&logTab=tree&filter=all&_focus=11567
[03:44:59]	 8/13 Test #484: test_dist_allreduce_op ...................***Failed   12.05 sec
[03:44:59]	W0725 03:44:50.381258 25062 init.cc:162] AVX is available, Please re-compile on local machine
[03:44:59]	� X>
  1. http://ci.paddlepaddle.org/viewLog.html?tab=buildLog&buildTypeId=Paddle_PrCiPython35&buildId=131286&_focus=11580
[06:50:39]	25/25 Test #553: test_dist_se_resnext_sync .................***Timeout 350.03 sec
[06:50:39]	Errors while running CTest

@luotao1
Copy link
Contributor

luotao1 commented Jul 25, 2019

@tianshuo78520a Could you help see it?

@luotao1 luotao1 requested review from jczaja, wojtuss and Sand3r- July 26, 2019 01:41
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move into good direction! LGTM

@luotao1 luotao1 changed the title UT Coverage : transpose_mkldnn_op.cc remove unused TransposeINT8MKLDNNOpKernel for higher UT coverage Jul 26, 2019
@luotao1 luotao1 merged commit b05bdda into PaddlePaddle:develop Jul 26, 2019
@lidanqing-intel lidanqing-intel deleted the UT-coverage-transpose branch July 15, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants