Polish fleet API to support cuda collective mode and nccl2 mode. #18966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| startup_program = startup_program if startup_program else \ | ||
| fluid.framework.default_startup_program | ||
| _check(main_program, self._optimizer, self._strategy) |
There was a problem hiding this comment.
could you specify what kind of check does this function do? maybe a detailed function name is needed
gongweibao
changed the title
| io.save_persistables(self._executor, dirname, main_program, None) | ||
| io.save_persistables(executor, dirname, main_program, None) | ||
|
|
||
| def node_num(self): |
There was a problem hiding this comment.
I think this function is not in fleet_base.py, we have a protocol that all sub class implementation should follow fleet_base.py inferface design.
|
luotao1
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polish fleet API to support cuda collective mode and nccl2 mode.