Fix OpTester from incorrectly converting uint8 data to utf-8 string #24854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
Please trigger the CI |
Sand3r-
force-pushed
the
mgallus/fix-optest-uint8-print
branch
from
96d227e
to
14e7005
Compare
|
@luotao1 All CIs have passed |
|
@luotao1 Could this PR be merged ? |
luotao1
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types: Bug fixes
PR changes: APIs
Describe: When uint8 datatype is to be outputted in the message by
_compare_expect_and_actual_outputs, direct cast using str(), causes to throw an error related to encoding (data is incorrectly treated as array of characters instead of array of numbers). To mitigate this, the data is cast to np.array which then can be safely cast to string.