Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add net_design doc #2547

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions doc/design/refactor_discuess/net_design.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Overfiew

整体设计上参考 caffe2的SimpleNet,即Net 是一组 operator 的集合,包含了operator相关的操作,比如Create, RunOps, Delete 等。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今天上午讨论的对外提供的接口包括:
AddOp
Run
这两个接口,
用户配置Net的接口为什么还需要Delete ?


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

推荐design doc英文写 ,请参考目录下其他design doc,Interface 需要列出来,并简单描述一下
不应出现比如,设计文档是确定的方案,大家可以review和后续修改 : )

Net 有如下一些特性:

- Net 管理其拥有的operator
- Net 本身不占用任何Variable资源
- Net 的调用方式类似 Functor,即 `output = net(inputs, scope)` ,其中
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请确认一下,这里是显式调用Net.Run吧?

- scope提供net执行所需要的全局Variable
- 输入一个或多个variable, `inputs`
- 返回一个variable, `output`

# API