-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api2.0 paddle.nn.Bilinear and paddle.nn.functional.bilinear #26399
api2.0 paddle.nn.Bilinear and paddle.nn.functional.bilinear #26399
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for op_function_generator.cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will merge
followup:
deprecate BilinearTensorProduct
python/paddle/nn/layer/common.py
Outdated
'ConstantPad3d', | ||
'ReplicationPad3d', | ||
'CosineSimilarity', | ||
'BilinearTensorProduct', 'Pool2D', 'Embedding', 'Linear', 'UpSample', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BilinearTensorProduct在这里可以直接删掉了。
相应的,
https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/fluid//dygraph/nn.py#L2356
这里可以加deprecated decorator。
9d514a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
todo:fix docs in another PR~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (conflict resolved)
PR types
New features
PR changes
APIs
Describe
一、背景
API2.0专项。
paddle.nn.Bilinear。
paddle.nn.functional.bilinear。
对应的老版本API:paddle.nn.BilinearTensorProduct
二、主要修改点:
三、主要测试点
四、未测试点