Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix syncbn, test=develop #26523

Merged
merged 3 commits into from
Aug 24, 2020
Merged

fix syncbn, test=develop #26523

merged 3 commits into from
Aug 24, 2020

Conversation

ceci3
Copy link
Contributor

@ceci3 ceci3 commented Aug 21, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

use_global_stats only support use_global_stats = false, fix it
move syncbn from fluid/dygraph to paddle/nn/norm
pre PR: #26032

@ceci3 ceci3 requested a review from willthefrog August 21, 2020 05:20
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

willthefrog
willthefrog requested changes Aug 23, 2020
View reviewed changes
python/paddle/nn/layer/norm.py Outdated Show resolved Hide resolved
@ceci3 ceci3 assigned jzhang533 and unassigned jzhang533 Aug 23, 2020
@ceci3 ceci3 requested a review from jzhang533 August 23, 2020 14:41
XiaoguangHu01
XiaoguangHu01 approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

willthefrog
willthefrog approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ceci3 ceci3 merged commit f8dbd7a into PaddlePaddle:develop Aug 24, 2020
@ceci3 ceci3 deleted the fix_syncbn branch August 24, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@willthefrog willthefrog willthefrog approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceci3 @jzhang533 @willthefrog @XiaoguangHu01