Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RandomSampler & BatchSampler. test=develop #26559

Merged
merged 5 commits into from
Aug 24, 2020
Merged

fix RandomSampler & BatchSampler. test=develop #26559

merged 5 commits into from
Aug 24, 2020

Conversation

heavengate
Copy link
Contributor

@heavengate heavengate commented Aug 22, 2020 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

  • fix paddle.io.RandomSampler cannot set num_samples for generator
  • fix paddle.io.BatchSampler shuffle not work
  • fix example code of paddle.io.BatchSampler and paddle.io.RandomSampler
    屏幕快照 2020-08-23 下午2 09 05
    屏幕快照 2020-08-23 下午2 09 17

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Heeenrrry
Heeenrrry approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@Heeenrrry Heeenrrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavengate heavengate merged commit dd3df69 into PaddlePaddle:develop Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heeenrrry Heeenrrry Heeenrrry approved these changes

@wangchaochaohu wangchaochaohu wangchaochaohu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heavengate @wangchaochaohu @Heeenrrry