-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【2.0 API】Add CUDA kernel and enhance options for grid_sample #26576
Merged
wanghaoshuang
merged 8 commits into
PaddlePaddle:develop
from
wanghaoshuang:grid_sample
Aug 24, 2020
Merged
【2.0 API】Add CUDA kernel and enhance options for grid_sample #26576
wanghaoshuang
merged 8 commits into
PaddlePaddle:develop
from
wanghaoshuang:grid_sample
Aug 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
test=develop
wanghaoshuang
requested review from
raindrops2sea,
qingqing01,
XiaoguangHu01,
baiyfbupt and
ceci3
August 23, 2020 10:57
heavengate
previously approved these changes
Aug 23, 2020
willthefrog
requested changes
Aug 23, 2020
test=develop
heavengate
approved these changes
Aug 24, 2020
raindrops2sea
approved these changes
Aug 24, 2020
a more detailed description is needed. |
willthefrog
approved these changes
Aug 24, 2020
lanxianghit
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPS
Describe
This PR enhance CPU kernel and add new CUDA kernel to make grid_sample support:
The old CPU and CUDNN version only support align_corners=true, padding_mode='zeros' and interpolation_mode='bilinear'.
The behavior of the new version op in default mode is compatible with the old version.