Improve Go cmake, add go/master/c into cmake include path.. #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
force-pushed
the
cmake
branch
5 times, most recently
from
7cc018e
to
31e1819
Compare
helinwang
changed the title
gangliao
reviewed
Jun 30, 2017
|
|
||
| add_custom_target(copy_paddle_master) | ||
| if(WITH_GOLANG) | ||
| add_custom_command(TARGET copy_paddle_master |
There was a problem hiding this comment.
configure_file(<input> <output> COPYONLY)
If the input file is modified the build system will re-run CMake to re-configure the file and generate the build system again.
There was a problem hiding this comment.
After talking with @gangliao , we decide not to change here, since it depends on target paddle_master, using add_custom_command can express dependency.
gangliao
reviewed
Jun 30, 2017
CMakeLists.txt
Outdated
| #TODO (add go/master/c back when fixed) | ||
| add_subdirectory(go/pserver/cclient) | ||
| # we need to symlink Paddle directory into GOPATH. If we | ||
| # don't do it and we have code that depends on Paddle, go |
There was a problem hiding this comment.
we can put this configuration into configure.cmake to keep the root CMAKE FILE as simple as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.