Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dimensions error for mobilenetv1_KL_quant #26776

Conversation

sfraczek
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

Fixed Error when running test_quant2_int8_mobilenetv1_mkldnn with the recieved mobilenetv1_KL_quant model.
The error that was fixed was AssertionError: The size of weight scales vector (1000) does not match the number of output channels (1024) in the weights tensor fc7_weights.
The reason was that the weights in this mul operator did not require transposition as in previous cases.

@sfraczek sfraczek requested a review from wojtuss August 28, 2020 09:10
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those new cases have to be covered in the test.

@sfraczek sfraczek force-pushed the mul-channelwise-quantization-dequantization branch from 1ee87b3 to b05bfb3 Compare September 3, 2020 15:11
fixes AssertionError: The size of weight scales vector (1000) does not match the number of output channels (1024) in the weights tensor fc7_weights.

add mul test
@sfraczek sfraczek force-pushed the mul-channelwise-quantization-dequantization branch from b05bfb3 to 65f0ebc Compare September 3, 2020 15:22
Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit eb65877 into PaddlePaddle:develop Sep 7, 2020
@sfraczek sfraczek deleted the mul-channelwise-quantization-dequantization branch September 7, 2020 09:10
@sfraczek sfraczek added the int8 label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants