-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method converting Tensor to Eigen TensorMap #2805
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1a968b4
init
QiJune d6f7c35
move unaligned tensor types
QiJune 9585111
add simple add_op_functor
QiJune d607f0b
use cached rank
QiJune a5eb1d8
fix build error
QiJune 37bcc08
merge baidu/develop
QiJune 71e2a94
Merge remote-tracking branch 'baidu/develop' into tensor_to_EigenTensor
QiJune 0b0b3ba
Merge remote-tracking branch 'baidu/develop' into tensor_to_EigenTensor
QiJune 6f2eba3
Merge remote-tracking branch 'baidu/develop' into tensor_to_EigenTensor
QiJune bac1426
add_op kernel implementation
QiJune d649dbf
implement add_op kernel
QiJune 9e3a9eb
merge baidu/develop
QiJune 65dbeb6
fix gpu build error
QiJune 5017b15
refactor tensor mutable_data
QiJune 6dc567a
merge baidu/develop
QiJune 2a03e38
set correct place for output tensor
QiJune 8718966
merge baidu/develop
QiJune 4d49f1d
merge baidu/develop
QiJune d344f67
Merge branch 'develop' into tensor_to_EigenTensor
QiJune File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. */ | ||
|
||
#pragma once | ||
|
||
#include "unsupported/Eigen/CXX11/Tensor" | ||
|
||
namespace paddle { | ||
namespace framework { | ||
|
||
// Helper to define Tensor types given that the scalar is of type T. | ||
template <typename T, int NDIMS = 1, typename IndexType = Eigen::DenseIndex> | ||
struct TTypes { | ||
// Rank-<NDIMS> tensor of scalar type T. | ||
typedef Eigen::TensorMap<Eigen::Tensor<T, NDIMS, Eigen::RowMajor, IndexType>, | ||
Eigen::Aligned> | ||
Tensor; | ||
typedef Eigen::TensorMap< | ||
Eigen::Tensor<const T, NDIMS, Eigen::RowMajor, IndexType>, Eigen::Aligned> | ||
ConstTensor; | ||
|
||
// Scalar tensor (implemented as a rank-0 tensor) of scalar type T. | ||
typedef Eigen::TensorMap< | ||
Eigen::TensorFixedSize<T, Eigen::Sizes<>, Eigen::RowMajor, IndexType>, | ||
Eigen::Aligned> | ||
Scalar; | ||
typedef Eigen::TensorMap<Eigen::TensorFixedSize<const T, Eigen::Sizes<>, | ||
Eigen::RowMajor, IndexType>, | ||
Eigen::Aligned> | ||
ConstScalar; | ||
|
||
// Rank-1 tensor (vector) of scalar type T. | ||
typedef Eigen::TensorMap<Eigen::Tensor<T, 1, Eigen::RowMajor, IndexType>, | ||
Eigen::Aligned> | ||
Flat; | ||
typedef Eigen::TensorMap< | ||
Eigen::Tensor<const T, 1, Eigen::RowMajor, IndexType>, Eigen::Aligned> | ||
ConstFlat; | ||
typedef Eigen::TensorMap<Eigen::Tensor<T, 1, Eigen::RowMajor, IndexType>, | ||
Eigen::Aligned> | ||
Vec; | ||
typedef Eigen::TensorMap< | ||
Eigen::Tensor<const T, 1, Eigen::RowMajor, IndexType>, Eigen::Aligned> | ||
ConstVec; | ||
|
||
// Rank-2 tensor (matrix) of scalar type T. | ||
typedef Eigen::TensorMap<Eigen::Tensor<T, 2, Eigen::RowMajor, IndexType>, | ||
Eigen::Aligned> | ||
Matrix; | ||
typedef Eigen::TensorMap< | ||
Eigen::Tensor<const T, 2, Eigen::RowMajor, IndexType>, Eigen::Aligned> | ||
ConstMatrix; | ||
}; | ||
|
||
} // namespace framework | ||
} // namespace paddle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
#include <paddle/operators/add_op.h> | ||
#include <paddle/framework/op_registry.h> | ||
#include "paddle/operators/add_op.h" | ||
#include "paddle/framework/op_registry.h" | ||
|
||
typedef paddle::operators::AddKernel<::paddle::platform::GPUPlace, float> AddKernel_GPU_float; | ||
REGISTER_OP_GPU_KERNEL(add_two, | ||
paddle::operators::AddKernel<paddle::platform::GPUPlace>); | ||
AddKernel_GPU_float); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,36 @@ | ||
/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. */ | ||
|
||
#pragma once | ||
#include <glog/logging.h> | ||
#include <paddle/framework/operator.h> | ||
#include "glog/logging.h" | ||
#include "paddle/framework/operator.h" | ||
|
||
namespace paddle { | ||
namespace operators { | ||
|
||
template <typename Place> | ||
template <typename Place, typename T> | ||
class AddKernel : public framework::OpKernel { | ||
public: | ||
void Compute(const framework::KernelContext &context) const override { | ||
LOG(INFO) << "Add kernel in " << typeid(Place).name(); | ||
void Compute(const framework::KernelContext& context) const override { | ||
auto input0 = context.Input(0)->Get<framework::Tensor>(); | ||
auto input1 = context.Input(1)->Get<framework::Tensor>(); | ||
auto* output = context.Output(0)->GetMutable<framework::Tensor>(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe output->mutable_data could hide in |
||
|
||
output->mutable_data<T>(context.GetPlace()); | ||
|
||
output->flat<T>().device(*(context.GetEigenDevice<Place>())) = | ||
input0.flat<T>() + input1.flat<T>(); | ||
} | ||
}; | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we always use
raw_data
in OpKernel. The mutable_data is only used for allocation. Maybe we could changemutable_data
toallocation