refine gpu kernel config for Paddle #28085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
LielinJiang
reviewed
Oct 19, 2020
| @@ -1,49 +1,103 @@ | |||
| /* Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. | |||
| // Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
这个文件也不是这个PR新增的，copyright年限不用改吧？另外，不要改文件权限。
LielinJiang
reviewed
Oct 19, 2020
| return config; | ||
| } | ||
|
|
||
| // 3D will add later |
There was a problem hiding this comment.
add a todo and your github id will be good
LielinJiang
approved these changes
Oct 19, 2020
Xreki
reviewed
Oct 20, 2020
| KeBicubicInterpFw< | ||
| T><<<config.blocks, 512, 0, ctx.cuda_device_context().stream()>>>( | ||
| KeBicubicInterpFw<T><<<config.block_per_grid, 512, 0, | ||
| ctx.cuda_device_context().stream()>>>( |
There was a problem hiding this comment.
这个有线程数调整，最好用op benchmark测下对OP性能的影响。
There was a problem hiding this comment.
这里和原来的逻辑是一致的
| @@ -1,49 +1,103 @@ | |||
| /* Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. | |||
| // Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
这个文件也不是这个PR新增的，copyright年限不用改吧？另外，不要改文件权限。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
APIs
Describe
统一gpu block 和grid 设置（现存两种设置方式）