-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build_android task on Travis CI. #2845
Conversation
a619cb0
to
976d92c
Compare
6a4a1e2
to
4f770d0
Compare
4f770d0
to
62908dc
Compare
# Compile paddle binaries | ||
cmake -DCMAKE_SYSTEM_NAME=Android \ | ||
-DANDROID_STANDALONE_TOOLCHAIN=$ANDROID_STANDALONE_TOOLCHAIN \ | ||
-DANDROID_ABI=armeabi-v7a \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之后会考虑类似arm64-v8a吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm64-v8a
的编译,@hedaoyuan 已经在#2816 中支持了,若觉得有必要,可以直接在这个脚本里加上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
经过和@gangliao 讨论,在Travis CI中增加build_android
编译任务的主要目的,是为了防止后续cmake的更新,导致android版编译失败,因而不需要再增加arm64-v8a
的编译测试。
cmake -DCMAKE_SYSTEM_NAME=Android \ | ||
-DANDROID_STANDALONE_TOOLCHAIN=$ANDROID_STANDALONE_TOOLCHAIN \ | ||
-DANDROID_ABI=armeabi-v7a \ | ||
-DANDROID_ARM_NEON=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-DWITH_TESTING=OFF disable build the test binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
线下编译的时候,一般都设置-DWITH_TESTING=ON
,生成的二进制拷贝到Android设备上运行。设置-DWITH_TESTING=ON
可以检查是否会有链接错误。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
明白了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost LGTM, pls follow the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
赞!
【说明】由于Paddle的重构工作,可能会引入一些临时的修改:
为了防止 |
No description provided.