Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_android task on Travis CI. #2845

Merged
merged 2 commits into from
Jul 14, 2017

Conversation

Xreki
Copy link
Contributor

@Xreki Xreki commented Jul 13, 2017

No description provided.

@Xreki Xreki force-pushed the travis_build_android branch 2 times, most recently from a619cb0 to 976d92c Compare July 13, 2017 08:50
@Xreki Xreki force-pushed the travis_build_android branch 4 times, most recently from 6a4a1e2 to 4f770d0 Compare July 13, 2017 11:48
# Compile paddle binaries
cmake -DCMAKE_SYSTEM_NAME=Android \
-DANDROID_STANDALONE_TOOLCHAIN=$ANDROID_STANDALONE_TOOLCHAIN \
-DANDROID_ABI=armeabi-v7a \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之后会考虑类似arm64-v8a吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arm64-v8a的编译,@hedaoyuan 已经在#2816 中支持了,若觉得有必要,可以直接在这个脚本里加上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

经过和@gangliao 讨论,在Travis CI中增加build_android编译任务的主要目的,是为了防止后续cmake的更新,导致android版编译失败,因而不需要再增加arm64-v8a的编译测试。

cmake -DCMAKE_SYSTEM_NAME=Android \
-DANDROID_STANDALONE_TOOLCHAIN=$ANDROID_STANDALONE_TOOLCHAIN \
-DANDROID_ABI=armeabi-v7a \
-DANDROID_ARM_NEON=ON \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DWITH_TESTING=OFF disable build the test binaries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

线下编译的时候,一般都设置-DWITH_TESTING=ON,生成的二进制拷贝到Android设备上运行。设置-DWITH_TESTING=ON可以检查是否会有链接错误。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

明白了

Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost LGTM, pls follow the comments.

Copy link
Contributor

@hedaoyuan hedaoyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞!

@Xreki
Copy link
Contributor Author

Xreki commented Jul 14, 2017

说明】由于Paddle的重构工作,可能会引入一些临时的修改:

  1. 新增代码
  2. 新增依赖库
  3. 修改编译和链接配置

为了防止build_android任务失败,可以在cmake中使用IF(NOT ANDROID)将修改与Android编译隔开,等代码结构稳定后,再统一来支持。

@Xreki Xreki merged commit bb8ac28 into PaddlePaddle:develop Jul 14, 2017
@Xreki Xreki added the Android label Sep 30, 2017
@Xreki Xreki deleted the travis_build_android branch October 18, 2017 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants