Faster glide #2869
Faster glide #2869
Conversation
| add_custom_command(TARGET go_path | ||
| message(STATUS "link ${CMAKE_SOURCE_DIR} to ${PADDLE_IN_GOPATH}...") | ||
|
|
||
| execute_process( |
There was a problem hiding this comment.
I think the execute_process will only run when cmake is executed (when running cmake .., or when cmake file changed). But it will not run every time make is called, or when glide.lock is changed.
Also it may be better not to delete the add_custom_target(go_vendor), since go build need to add dependency to go_vendor target as well, otherwise go build may start before or concurrently with glide install.
This is an interesting problem, I gave it a try as well, can you take a look? #2884
There was a problem hiding this comment.
Interesting, don't know why travis didn't run successfully. Well, if compiling with cmake, the vendor will be prepared at cmake time, and following go build will pass. Seems #2884 is better~ Thanks~
So when make and make test for go programs it will be faster.
Fix #2868