Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: cpplint code style #2888

Merged
merged 4 commits into from
Jul 15, 2017
Merged

FIX: cpplint code style #2888

merged 4 commits into from
Jul 15, 2017

Conversation

gangliao
Copy link
Contributor

@gangliao gangliao commented Jul 15, 2017 •
edited
Loading

It's better to add cpplint.py into generic.cmake. Also, I found the previous cpplint.cmake doesn't work, so I changed it.

@gangliao gangliao requested a review from wangkuiyi July 15, 2017 02:10
@gangliao gangliao requested review from reyoung and QiJune July 15, 2017 02:19
wangkuiyi
wangkuiyi approved these changes Jul 15, 2017
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gangliao gangliao merged commit 9b8451c into PaddlePaddle:develop Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@QiJune QiJune Awaiting requested review from QiJune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gangliao @wangkuiyi @emailweixu