Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine tensor's conditional compilation, remove Tensor::numel_ and add DDim::size() #2926

Merged
merged 2 commits into from
Jul 17, 2017
Merged

refine tensor's conditional compilation, remove Tensor::numel_ and add DDim::size() #2926

merged 2 commits into from
Jul 17, 2017

Conversation

JiayiFeng
Copy link
Collaborator

No description provided.

@JiayiFeng JiayiFeng requested a review from QiJune July 17, 2017 11:54
@JiayiFeng JiayiFeng changed the title refine conditional compilation and remove numel_ refine tensor's conditional compilation, remove numel_ and add DDim::size() Jul 17, 2017
@JiayiFeng JiayiFeng requested a review from luotao1 July 17, 2017 12:02
@JiayiFeng JiayiFeng changed the title refine tensor's conditional compilation, remove numel_ and add DDim::size() refine tensor's conditional compilation, remove Tensor::numel_ and add DDim::size() Jul 17, 2017
wangkuiyi
wangkuiyi approved these changes Jul 17, 2017
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangkuiyi wangkuiyi merged commit efd9809 into PaddlePaddle:develop Jul 17, 2017
@JiayiFeng JiayiFeng deleted the dev_enable_tensor_test branch August 1, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@QiJune QiJune Awaiting requested review from QiJune

@luotao1 luotao1 Awaiting requested review from luotao1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiayiFeng @wangkuiyi