Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CreateOp in Plain C++ params #2936

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Make CreateOp in Plain C++ params #2936

merged 1 commit into from
Jul 18, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jul 18, 2017

No description provided.

@reyoung reyoung requested a review from jacquesqiao July 18, 2017 07:22
jacquesqiao
jacquesqiao approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit fb48cb1 into PaddlePaddle:develop Jul 18, 2017
@reyoung reyoung deleted the feature/create_op_in_cpp_params branch July 19, 2017 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @jacquesqiao