add cross-entropy-op #2965
Merged
add cross-entropy-op #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cross-entropy-op
… cross-entropy-op
wangkuiyi
reviewed
Jul 20, 2017
| template <typename Place, typename T> | ||
| class OnehotCrossEntropyOpKernel : public framework::OpKernel { | ||
| public: | ||
| constexpr T LOG_THRESHOLD() const { return static_cast<T>(1e-20); } |
There was a problem hiding this comment.
Would it be easier to have constant instead of a function here?
I tried the following program builds and runs:
#include <iostream>
template <typename T>
struct Hello {
const T kThreshold = static_cast<T>(1e-20);
};
int main() {
Hello<float> h;
std::cout << h.kThreshold << "\n";
return 0;
}There was a problem hiding this comment.
constexpr可以实现编译时求值，没有了运行时调用的开销，是觉得这个使用方法不够直接么？
| int batch_size = X.dims()[0]; | ||
| int class_num = X.dims()[1]; | ||
|
|
||
| // Y[i] = -log(X[i][j]) |
There was a problem hiding this comment.
Remove the code if it is unnecessary?
There was a problem hiding this comment.
This is the formula for onehot-cross-entropy, I put it here to help readers get an easier understanding of the following computation logic. May be I should write with more detail?
luotao1
approved these changes
Jul 21, 2017
| @@ -48,6 +48,7 @@ op_library(mul_op SRCS mul_op.cc mul_op.cu) | |||
| op_library(rowwise_add_op SRCS rowwise_add_op.cu rowwise_add_op.cc) | |||
| op_library(sigmoid_op SRCS sigmoid_op.cu sigmoid_op.cc) | |||
| op_library(softmax_op SRCS softmax_op.cc softmax_op.cu) | |||
| op_library(cross_entropy_op SRCS cross_entropy_op.cc cross_entropy_op.cu) | |||
There was a problem hiding this comment.
和这个PR无关，请问现在的CMakeLists必须一行行手写么？不能对这个目录下的文件进行自动编译么？ @gangliao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.