support vector<float64> as type of op attribute and op set_value suppport float64 numpy.array #30126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
liym27
force-pushed
the
setitem_support_attr_float64
branch
from
eb908ce to
f78a3e9
Compare
liym27
force-pushed
the
setitem_support_attr_float64
branch
from
f78a3e9 to
b114d7a
Compare
liym27
changed the title
…port float64 numpy.array
liym27
force-pushed
the
setitem_support_attr_float64
branch
from
b114d7a to
52b40d4
Compare
zhhsplendid
reviewed
Jan 6, 2021
| std::vector<double>* operator()(Attribute& attr) const { | ||
| if (attr.type() == typeid(std::vector<int>)) { // NOLINT | ||
| std::vector<int> val = BOOST_GET_CONST(std::vector<int>, attr); | ||
| std::vector<double> vec(val.begin(), val.end()); |
There was a problem hiding this comment.
This code is inefficient because line 176 will construct vec by iterating the vector and then attr = vec will do an iterating copy.
Can you convert val to attr inplace so that it just iterates once?
Same as line 179 - line 181
| explicit ExtractAttribute(const std::string& attr_name) | ||
| : attr_name_(attr_name) {} | ||
|
|
||
| std::vector<double>* operator()(Attribute& attr) const { |
There was a problem hiding this comment.
Just knowledge, not your fault. Our C++ style requires the change-able input parameter attr as a pointer, but I read the old code doesn't follow the style...
So you don have to change anything. It is just a kindly remind comment :-)
liym27
added a commit
to liym27/Paddle
that referenced
this pull request
Jan 11, 2021
…et_value suppport vector<double> as value (PaddlePaddle#30126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
vector<float64>as type of op attribute.set_valuesuppportsfloat64numpy.array