[oneDNN] Cache oneDNN stream not to recreate in each oneDNN op #30358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- compilation fix - fix - Fix - fix - added stream holder - compilation fix - Modified all remining files - fix - lint
|
Thanks for your contribution! |
|
@arogowie-intel I have added some additional change (last commit) to fix a problem exposed by test-analyzer-detect. If you want more details then ask me. |
|
@luotao1 Could you please start your review? CI will not pass without approval. This PR is changing way oneDNN stream was created , so due to API change I had do it all at once in all locations. So there many files modified, but most of them it is single line of change. |
arogowie-intel
approved these changes
Jan 20, 2021
luotao1
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
created on dnnl::stream involves small memory allocation. stream can be created once and then reused so this PR makes stream to be created one per thread and store in per thread object.