Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish ParallelExectuor constructor into small functions #30544

Closed
wants to merge 7 commits into from

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Jan 18, 2021

PR types

Others

PR changes

Others

Describe

Polish ParallelExectuor constructor into small functions

1. PR 背景:

ParallelExecutor执行器构造函数逻辑过于复杂,非常不利于后续其他模块复用此代码,比如动转静执行器升级PE工作。

2. PR 内容:

对ParallelExectuor构造函数进行了逻辑拆分,增强代码的可读性和可复用性。本PR为动转静升级PE的前序工作,不涉及新功能增加。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Aurelius84
❌ root


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Aurelius84 Aurelius84 changed the title Polish PE logic Polish ParallelExectuor constructor into functions Jan 20, 2021
@Aurelius84 Aurelius84 changed the title Polish ParallelExectuor constructor into functions Polish ParallelExectuor constructor into small functions Jan 20, 2021
@paddle-bot-old
Copy link

Sorry to inform you that a059983's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@Aurelius84
Copy link
Contributor Author

see new PR: #32191

@Aurelius84 Aurelius84 closed this Apr 12, 2021
@Aurelius84 Aurelius84 deleted the replace_with_PE branch April 12, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants