fix bug in OpKernel register macro #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
requested changes
Jul 26, 2017
| @@ -199,7 +199,9 @@ class OperatorWithKernel : public OperatorBase { | |||
| place_ = dev_ctx.GetPlace(); | |||
| } | |||
|
|
|||
| bool operator==(const OpKernelKey& o) const { return place_ == o.place_; } | |||
| bool operator==(const OpKernelKey& o) const { | |||
There was a problem hiding this comment.
Operator应该是不可比较的。operator==应该改成 IsSameDevice
There was a problem hiding this comment.
这里比较的不是Operator，是OpKernelKey；目的是区分CPU和GPU对应着不同的OpKernel。
这里重载operator== 主要是当OpKernelKey作为unorder_map的key时，需要重载一个判断key是否相同的方法。
There was a problem hiding this comment.
这里会触发 GPUPlace(0) 与 GPUPlace(1) 对应不是一个OpKernel的bug
|
能解释下这个bug的触发场景么，看起来之前编译就应该报错才对？ |
|
@jacquesqiao REGISTER_OP_GPU_KERNEL/REGISTER_OP_CPU_KERNEL宏的展开分别在.cu 和 .cc里面，因此之前不会有冲突。 |
wangkuiyi
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.