fix windows for optimization of elementwise_add Op #31068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution! |
zhwesky2010
reviewed
Feb 20, 2021
| @@ -315,7 +315,7 @@ class ElementwiseAddGradKernel : public ElemwiseGradKernel<T> { | |||
| // skip out | |||
| auto *out = dout; | |||
|
|
|||
| #ifdef PADDLE_WITH_CUDA | |||
| #if defined(PADDLE_WITH_CUDA) && defined(_LINUX) | |||
There was a problem hiding this comment.
better to add TODO for Windows
zhwesky2010
approved these changes
Feb 22, 2021
wangchaochaohu
added a commit
that referenced
this pull request
Feb 24, 2021
This reverts commit 364cfa2.
This was referenced Feb 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
修复conv2d_transpose 在window下出现的精度问题