Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning message when dtypes of operator are not same #31136

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

MingMingShangTian
Copy link
Contributor

@MingMingShangTian MingMingShangTian commented Feb 23, 2021

PR types

Others

PR changes

Others

Describe

When the dtypes of left variable and right variable are not the same, the operator compute (such as +-*/) will follow with the left variable dtypes. This PR add the warning message to the users.

The problem:
image

image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MingMingShangTian MingMingShangTian changed the title add error msg when dtypes of operator are not same add warning message when dtypes of operator are not same Feb 23, 2021
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 70131b4 into PaddlePaddle:develop Feb 24, 2021
@MingMingShangTian MingMingShangTian deleted the operator_error_msg branch February 24, 2021 02:30
MingMingShangTian added a commit to MingMingShangTian/Paddle that referenced this pull request Feb 24, 2021
…e#31136)

* add error msg when dtypes of operator are not same

* add error msg when dtypes of operator are not same

* change error msg to warning msg when dtypes of operator are not same

* modify test case to fit for python2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants