cpu/gpu mean op and its unit test #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
commented
Aug 2, 2017
|
|
||
| output->mutable_data<T>(context.GetPlace()); | ||
|
|
||
| EigenScalar<T>::From(*output).device(*(context.GetEigenDevice<Place>())) = |
There was a problem hiding this comment.
Tensor2Eigen still not easy to w/r.
gangliao
changed the title
dzhwinter
reviewed
Aug 2, 2017
| public: | ||
| MeanOpMaker(OpProto *proto, OpAttrChecker *op_checker) | ||
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput("X", "The input of mean op"); |
There was a problem hiding this comment.
maybe we need a axis parameter to indicate which axis will be computed.
There was a problem hiding this comment.
discussed with @reyoung Currently, we only need all mean operator.
Superjomn
reviewed
Aug 2, 2017
| self.X = np.random.random((32, 784)).astype("float32") | ||
| self.Out = np.mean(self.X) | ||
|
|
||
|
|
There was a problem hiding this comment.
no real test here ?
check if mean_op's output equals inputs's mean
There was a problem hiding this comment.
It looks it already did where OpTestMeta took this job.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review after #3133