Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittest for FillZerosLikeOp #3142

Merged
merged 14 commits into from
Aug 7, 2017
Merged

Add unittest for FillZerosLikeOp #3142

merged 14 commits into from
Aug 7, 2017

Conversation

JiayiFeng
Copy link
Collaborator

Add unittest for FillZerosLikeOp, which is used in Backward.

@JiayiFeng JiayiFeng requested review from reyoung and dzhwinter August 1, 2017 18:33
jacquesqiao
jacquesqiao reviewed Aug 1, 2017
View reviewed changes
python/paddle/v2/framework/tests/test_fill_zeros_like_op.py Outdated
import numpy


class TestFillZerosLikeOp(unittest.TestCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请参考现有Op Python单测，用测试框架写单测

@JiayiFeng JiayiFeng self-assigned this Aug 2, 2017
dzhwinter
dzhwinter approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! need to fix the conflict before merge.

reyoung
reyoung approved these changes Aug 3, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@JiayiFeng JiayiFeng merged commit 65f953a into PaddlePaddle:develop Aug 7, 2017
@JiayiFeng JiayiFeng deleted the dev_add_FillZerosLikeOp_test branch August 7, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao left review comments

@reyoung reyoung reyoung approved these changes

@dzhwinter dzhwinter dzhwinter approved these changes

Assignees

@JiayiFeng JiayiFeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JiayiFeng @reyoung @jacquesqiao @dzhwinter