Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify building process of gradient operators #3192

Merged
merged 3 commits into from
Aug 3, 2017
Merged

Simplify building process of gradient operators #3192

merged 3 commits into from
Aug 3, 2017

Conversation

JiayiFeng
Copy link
Collaborator

fixes #3151

@JiayiFeng JiayiFeng requested review from reyoung and dzhwinter August 2, 2017 23:58
dzhwinter
dzhwinter approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paddle/framework/backward_test.cc
@@ -161,8 +161,8 @@ TEST(Backward, simple_op_grad) {
auto fwd = f::OpRegistry::CreateOp("rowwise_add", {"X", "b"}, {"Out"}, {});
ASSERT_NE(fwd, nullptr);
auto gop = f::OpRegistry::CreateGradOp(*fwd);
ASSERT_EQ(1UL, gop->inputs_.size());
ASSERT_EQ("Out" + f::OperatorBase::GRAD_VAR_SUFFIX(), gop->inputs_[0]);
ASSERT_EQ(4UL, gop->inputs_.size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I, O , OG" seems we really need 4UL, but why it pass the test smoothly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it in this PR, it was 1UL and now is 4UL.

paddle/framework/grad_op_builder.cc Outdated
int end_idx = format.empty() ? idx + 1 : format.at(idx + 1);
return new OpInOutArg(var.name(), type, !var.ignore_gradient(), begin_idx,
end_idx);
enum OpArgType { IN, OUT };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe enum class is better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@JiayiFeng JiayiFeng merged commit 6f12fd2 into PaddlePaddle:develop Aug 3, 2017
@JiayiFeng JiayiFeng deleted the dev_simplify_GradOpBuilder branch August 3, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify building process of gradient operators
2 participants
@JiayiFeng @dzhwinter