Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCM] fix depthwise conv failure on ROCM, test=develop #31998

Merged
merged 1 commit into from
Apr 1, 2021
Merged

[ROCM] fix depthwise conv failure on ROCM, test=develop #31998

merged 1 commit into from
Apr 1, 2021

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented Mar 31, 2021

PR types

Bug fixes

PR changes

OPs

Describe

ROCM平台上depth-wise conv的线程数在output较大是超过256，因此导致core dump

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@qili93 qili93 requested review from Xreki and jerrywgz April 1, 2021 06:56
jerrywgz
jerrywgz approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@jerrywgz jerrywgz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit a4b30a1 into PaddlePaddle:develop Apr 1, 2021
@qili93 qili93 deleted the fix_convdepth branch April 1, 2021 10:53
@qili93 qili93 mentioned this pull request Apr 7, 2021
Closed
@qili93 qili93 mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrywgz jerrywgz jerrywgz approved these changes

@Xreki Xreki Awaiting requested review from Xreki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qili93 @jerrywgz