Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCM] fix the backward maxpool #32030

Merged
merged 1 commit into from
Apr 6, 2021
Merged

[ROCM] fix the backward maxpool #32030

merged 1 commit into from
Apr 6, 2021

Conversation

ronny1996
Copy link
Contributor

@ronny1996 ronny1996 commented Apr 1, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

fix the backward maxpool

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

qili93
qili93 previously approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 requested a review from zhiqiu April 2, 2021 04:42
@ronny1996 ronny1996 changed the title [ROCM] added a FLAGS_pool2d_disable_cudnn to disable cudnn for pool2d [ROCM] fix the backward maxpool Apr 2, 2021
@ronny1996 ronny1996 requested a review from qili93 April 2, 2021 09:29
qili93
qili93 previously approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronny1996 ronny1996 requested a review from qili93 April 6, 2021 02:04
qili93
qili93 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit a3b08ba into PaddlePaddle:develop Apr 6, 2021
ronny1996 added a commit to ronny1996/Paddle that referenced this pull request Apr 6, 2021
@ronny1996
[ROCM] fix the backward maxpool (PaddlePaddle#32030)
cb97a9a
qili93 pushed a commit that referenced this pull request Apr 6, 2021
@ronny1996
[ROCM] fix the backward maxpool (#32030) (#32080)
7bd0227
@ronny1996 ronny1996 deleted the bugfix_pool2d branch April 6, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qili93 qili93 qili93 approved these changes

@zhiqiu zhiqiu Awaiting requested review from zhiqiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronny1996 @qili93