fix two error message #32039
Merged
fix two error message #32039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Apr 2, 2021
paddle/fluid/operators/scatter.h
Outdated
| @@ -104,7 +104,10 @@ void ScatterAssign(const platform::DeviceContext& ctx, const Tensor& src, | |||
| for (int i = 1; i < src_dims.size(); i++) | |||
| PADDLE_ENFORCE_EQ(src_dims[i], dst_dims[i], | |||
| platform::errors::InvalidArgument( | |||
| "src shape and dst shape should match")); | |||
| "src's shape and dst's shape should match." | |||
There was a problem hiding this comment.
- 建议使用完整单词表述，src, dst, dim这种都不是标准单词
- 建议首字母大写
- 这个shape和dim表示的是同一个意思，建议统一都用dimension
- 这里是第几维度不一致，表述要准确
- 后面的对比句子句法有误
比如可以改为：The dimensions of the source tensor and target tensor should match, but received source tensor's %d-th dimension is %d, target tensor's %d-th dimension is %d.
paddle/fluid/operators/scatter.h
Outdated
| @@ -148,7 +151,10 @@ void ScatterAssignAdd(const framework::ExecutionContext& ctx, const Tensor& src, | |||
| for (int i = 1; i < src_dims.size(); i++) | |||
| PADDLE_ENFORCE_EQ(src_dims[i], dst_dims[i], | |||
| platform::errors::InvalidArgument( | |||
| "src shape and dst shape should match")); | |||
| "src's shape and dst's shape should match," | |||
paddle/fluid/operators/unstack_op.cc
Outdated
| @@ -101,14 +101,19 @@ class UnStackGradOp : public framework::OperatorWithKernel { | |||
| void InferShape(framework::InferShapeContext *ctx) const override { | |||
| PADDLE_ENFORCE_GT(ctx->Inputs(framework::GradVarName("Y")).size(), 0, | |||
| platform::errors::InvalidArgument( | |||
| "Number of Inputs(Y@Grad) must be larger than 0")); | |||
| "Number of Inputs(Y@Grad) must be larger than 0." | |||
There was a problem hiding this comment.
这里是不太自然的，其实要表达的意思就是的输入为空吧，目前这个比较绕，直接告诉用户这里是空就好了, The Inputs(Y@Grad) of unstack operator are empty.
paddle/fluid/operators/unstack_op.cc
Outdated
| OP_INOUT_CHECK(ctx->HasOutput(framework::GradVarName("X")), "Output", "X", | ||
| "UnStackGrad"); | ||
| auto input_dims = ctx->GetInputsDim(framework::GradVarName("Y")); | ||
| for (size_t i = 1; i < input_dims.size(); ++i) { | ||
| PADDLE_ENFORCE_EQ(input_dims[i], input_dims[0], | ||
| platform::errors::InvalidArgument( | ||
| "Dims of all Inputs(Y@Grad) must be the same")); | ||
| "Dims of all Inputs(Y@Grad) must be the same," |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
fix two error message