-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Deepmd Support】add IsInitialized and tanh double grad #32188
Conversation
Thanks for your contribution! |
@@ -113,6 +113,9 @@ class PD_DLL_DECL Tensor { | |||
/// \brief Cast datatype from one to another | |||
Tensor cast(const DataType& target_type) const; | |||
|
|||
/// \brief Check Tensor is initialized | |||
bool IsInitialized() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API名其他都是小写,都统一成小写?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tanh double grad LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
OPs
Describe
This PR add IsInitialized API into paddle::Tensor to support user check whether their input tensor is ready to support deepmd custom op in PR https://github.com/deepmodeling/deepmd-kit/pull/499
And Add tanhDoubleGrad kernel to support SEA net work of deepmd
https://github.com/deepmodeling/deepmd-kit/blob/api/examples/water/train/water_se_a.json